Restack 1.1 macros and symbols to meet spec changes #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Confirmed this is consistent with ion-rust as of amazon-ion/ion-rust#879
popematt
requested changes
Dec 12, 2024
There was a problem hiding this comment.
I'm not sure quite what's going on with the ion-tests submodule update that's included in this PR. Naturally, some conformance tests will likely fail if the symbols have been restacked in ion-java without being also updated in ion-tests.
Can you
- make sure that the
ion-testscommit you are using in this PR is one that is already present inmain(ofion-tests)? - add the failing tests to the skip-list in
ConformanceTestRunner, along with a note what change caused the tests to start failing?
Comment on lines
+61
to
+62
| MakeList(14, MAKE_LIST, listOf(zeroToManyTagged("sequences")), null), // TODO: make_list | ||
| MakeSExp(15, MAKE_SEXP, listOf(zeroToManyTagged("sequences")), null), // TODO: make_sexp |
There was a problem hiding this comment.
Non-blocking—the nulls are unnecessary.
There was a problem hiding this comment.
I'll fix that, thanks.
|
I know what's going wrong with |
jobarr-amzn
force-pushed
the
restack-macros-symbols
branch
from
3036250 to
b05276a
Compare
…java Co-authored-by: Tyler Gregg <[email protected]>
tgregg
added a commit
that referenced
this pull request
Dec 13, 2024
* Restack macros and symbols to meet spec changes * Update ion-tests for symbol and macro restack * Fix comment in src/test/java/com/amazon/ion/impl/bin/WriteBufferTest.java Co-authored-by: Tyler Gregg <[email protected]> --------- Co-authored-by: Tyler Gregg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: amazon-ion/ion-rust#879
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.