-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Huffman Encoding edge case failure for assembly x64 #662
Conversation
Is anyone actually able to review this? If not, I am happy to run it locally and try to figure it out, but I would need a little help figuring out how to do that. |
[lang: asm] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and it produces the correct output. Thanks!
[If anyone wants to test this themselves, change the text
variable to something like aaaaaaaaaa
and compile it with gcc -no-pie huffman.s
]
I think that [code] line length should be checked by a CI task / GitHub action or something similar in the future, so I think we can merge this one (and fix the line length later on with other ones that will fail when this gets enforced). |
Imo we should aim for the editor to support wordwrap rather than have the maintainers be responsible for checking line length |
I created an issue (see #962) to separate the discussion about long lines and unblock this PR. |
Since this has been approved and a specific issue has been opened, I'm merging this in |
No description provided.