Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about code line length #962

Open
4 tasks
stormofice opened this issue Dec 1, 2021 · 2 comments
Open
4 tasks

Discussion about code line length #962

stormofice opened this issue Dec 1, 2021 · 2 comments
Labels
Discussion This is open for a discussion.

Comments

@stormofice
Copy link
Contributor

Description

Currently code blocks in the AAA handle lines [which are longer than possible (for the current view width)] by inserting a scroll bar on the bottom of the code block and making it scrollable horizontally.

Long (one-line) code comments (as shown in #662) can create pretty long lines, which may not be suitable/comfortable to view on devices with narrow screens, so it may be time to think about alternative solutions for displaying overly long code lines.

For Algorithm Archive Developers

  • This feature can be added to the Master Overview (if it cannot be, explain why in a comment below -- lack of technical expertise, not relevant to the scope of this project, too ambitious)
  • There is a timeline for when this feature can be implemented
  • The feature has been added to the Master Overview
  • The feature has been implemented (Please link the PR)
@leios
Copy link
Member

leios commented Dec 1, 2021

We used to have a "soft rule" of 80 columns a while back, which was enforced by several linters, but these had to be run locally. Now that we have a more robust build system, I wonder how hard it would be to enforce certain rules for most languages?

I think the problem is that some linters (like Julia's) do not deal with comment-length, which is the exact purpose of this PR, but I think I know how to fix that and can see if I can push it upstream, maybe?

@ntindle
Copy link
Member

ntindle commented Dec 1, 2021

We could run linters yes, but I would also like to fix the editor to wrap overflow.

@ShadowMitia ShadowMitia added the Discussion This is open for a discussion. label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion This is open for a discussion.
Projects
None yet
Development

No branches or pull requests

4 participants