Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Terms & Conditions #193

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix for Terms & Conditions #193

merged 3 commits into from
Dec 19, 2024

Conversation

philogicae
Copy link
Member

@philogicae philogicae self-assigned this Dec 12, 2024
Copy link

Summary:
This PR introduces a new configuration setting for the IPFS gateway URL. This change is straightforward and does not affect existing functionality significantly. It primarily serves to update the configuration for accessing IPFS resources, which is a minor update focused on improving the SDK's capabilities without altering its core behavior.

Highlight:

@@ -85,6 +85,7 @@ class Settings(BaseSettings):
 
     VM_URL_PATH = "https://aleph.sh/vm/{hash}"
     VM_URL_HOST = "https://{hash_base32}.aleph.sh"
+    IPFS_GATEWAY = "https://ipfs.aleph.cloud/ipfs/"
 
     # Web3Provider settings
     TOKEN_DECIMALS = 18

This change is a straightforward addition to the configuration, aimed at improving the SDK's ability to interact with IPFS, without introducing any new features or altering existing functionalities. It is a maintenance update that enhances the SDK's capabilities without increasing the risk of introducing bugs.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Dec 12, 2024
olethanh
olethanh previously approved these changes Dec 12, 2024
@philogicae philogicae changed the title Add IPFS Gateway to conf Fix for Terms & Conditions Dec 13, 2024
@philogicae philogicae force-pushed the feat-add-ipfs-gateway branch from 97803a9 to 56eb34e Compare December 13, 2024 12:38
src/aleph/sdk/client/http.py Show resolved Hide resolved
@philogicae philogicae merged commit 964020c into main Dec 19, 2024
12 checks passed
@philogicae philogicae deleted the feat-add-ipfs-gateway branch December 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants