Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Terms & Conditions #311

Open
wants to merge 1 commit into
base: fix-various-improvements
Choose a base branch
from

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Dec 2, 2024

Jira Tasks:

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

Add Terms & conditions feature

How to test

Create an instance on a T&C CRN, then display your instance list

TODO

@philogicae philogicae force-pushed the feat-terms-and-conditions branch from 610963e to 4505be6 Compare December 2, 2024 17:48
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 61.90476% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.61%. Comparing base (575c7bf) to head (bed45d7).

Files with missing lines Patch % Lines
src/aleph_client/commands/instance/__init__.py 36.36% 4 Missing and 3 partials ⚠️
src/aleph_client/models.py 68.18% 3 Missing and 4 partials ⚠️
src/aleph_client/commands/instance/display.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           fix-various-improvements     #311      +/-   ##
============================================================
+ Coverage                     54.47%   54.61%   +0.14%     
============================================================
  Files                            18       18              
  Lines                          2537     2578      +41     
  Branches                        320      328       +8     
============================================================
+ Hits                           1382     1408      +26     
- Misses                          993     1002       +9     
- Partials                        162      168       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae force-pushed the feat-terms-and-conditions branch from 4505be6 to 99dcc6b Compare December 2, 2024 18:01
@philogicae philogicae self-assigned this Dec 2, 2024
@philogicae philogicae force-pushed the feat-terms-and-conditions branch 2 times, most recently from cd802fe to 62671ff Compare December 11, 2024 11:20
@aleph-im aleph-im deleted a comment from github-actions bot Dec 11, 2024
Copy link
Contributor

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments/nitpicks from reading the code. I haven't tested it yet.

tests/unit/test_commands.py Outdated Show resolved Hide resolved
src/aleph_client/commands/files.py Outdated Show resolved Hide resolved
src/aleph_client/commands/files.py Outdated Show resolved Hide resolved
@philogicae philogicae force-pushed the feat-terms-and-conditions branch 2 times, most recently from dd97736 to c6a1f28 Compare December 13, 2024 13:43
@philogicae philogicae force-pushed the feat-terms-and-conditions branch from c6a1f28 to f79ea20 Compare January 9, 2025 21:18
@philogicae philogicae changed the base branch from master to fix-various-improvements January 9, 2025 21:19
@philogicae philogicae requested a review from nesitor January 10, 2025 13:00
@philogicae philogicae force-pushed the feat-terms-and-conditions branch 4 times, most recently from 6734e0c to 5adad5e Compare January 14, 2025 10:24
@philogicae philogicae force-pushed the feat-terms-and-conditions branch from 5adad5e to bed45d7 Compare January 15, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants