Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Message.time was float, becomes datetime #40

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Change: Message.time was float, becomes datetime #40

merged 6 commits into from
Nov 25, 2023

Commits on Nov 24, 2023

  1. Change: Message.time was float, becomes datetime 

    Change the type if BaseMessage.time to a datetime. This allows easier manipulation of the field, and parsing from strings as well as floats.

New APIs introduced in PyAleph 0.5.0 store the message time as timestampz and return it as ISO strings. This changes is compatible with both the old and new APIs.
    @hoh @MHHukiewitz
    hoh authored and MHHukiewitz committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7793807 View commit details
    Browse the repository at this point in the history

  2. Add time validator for auto-conversion from float to datetime

    @MHHukiewitz
    MHHukiewitz committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    fc79b57 View commit details
    Browse the repository at this point in the history

  3. Fix missing parameter

    @MHHukiewitz
    MHHukiewitz committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    78f84cd View commit details
    Browse the repository at this point in the history

  4. Fix Dockerfile dependency installation

    @MHHukiewitz
    MHHukiewitz committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    fba6fc0 View commit details
    Browse the repository at this point in the history

  5. Fix typing issues with mypy by using a generic type for AlephMessage

    @MHHukiewitz
    MHHukiewitz committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2a0f34d View commit details
    Browse the repository at this point in the history

  6. Rename to convert_float_to_datetime 

    Co-authored-by: Hugo Herter <[email protected]>
    @MHHukiewitz @hoh
    MHHukiewitz and hoh authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    be4371c View commit details
    Browse the repository at this point in the history