Change: Message.time was float, becomes datetime #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BjrInt
approved these changes
Jan 28, 2023
|
This would send datetimes as strings, which is likely not compatible with the MongoDB API - we should wait for the PostgreSQL based version of PyAleph to release this. |
|
Moved as draft, all nodes should be upgraded to use Postgres beforehand. |
Nodes are using Postgres now, should we continue pursing this PR? |
|
Add a @validator to convert float to datetime |
|
@hoh it's ready |
MHHukiewitz
force-pushed
the
hoh-time-datetime
branch
from
a5a42f9
to
40befe9
Compare
Change the type if BaseMessage.time to a datetime. This allows easier manipulation of the field, and parsing from strings as well as floats. New APIs introduced in PyAleph 0.5.0 store the message time as timestampz and return it as ISO strings. This changes is compatible with both the old and new APIs.
MHHukiewitz
force-pushed
the
hoh-time-datetime
branch
from
40befe9
to
fba6fc0
Compare
hoh
commented
Nov 24, 2023
Co-authored-by: Hugo Herter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the type if BaseMessage.time to a datetime. This allows easier manipulation of the field, and parsing from strings as well as floats.
New APIs introduced in PyAleph 0.5.0 store the message time as timestampz and return it as ISO strings. This changes is compatible with both the old and new APIs.