Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type parameters for some generic types (pt. 2) #951

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

injust
Copy link
Contributor

@injust injust commented Aug 7, 2024

Changes

Add type parameters for a generic type (Callable) that I missed in #950

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #999, the entry should look like this:

* Fix big bad boo-boo in the async scheduler (#999 <https://github.com/agronholm/apscheduler/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

Forgot about this `Callable`
@coveralls
Copy link

Coverage Status

coverage: 92.217%. remained the same
when pulling 4e84225 on injust:types
into 26e5869 on agronholm:master.

@agronholm agronholm merged commit 27c6826 into agronholm:master Aug 7, 2024
13 checks passed
@injust injust deleted the types branch August 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants