Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type parameters for some generic types #950

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

injust
Copy link
Contributor

@injust injust commented Aug 6, 2024

Changes

Add type parameters for some generic types (Callable, Iterable, and TaskStatus)

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #999, the entry should look like this:

* Fix big bad boo-boo in the async scheduler (#999 <https://github.com/agronholm/apscheduler/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

- Callable
- Iterable
- TaskStatus
@injust injust changed the title Add type parameters for generic types Add type parameters for some generic types Aug 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 92.217%. remained the same
when pulling 1eabad7 on injust:types
into 25cac59 on agronholm:master.

@injust
Copy link
Contributor Author

injust commented Aug 6, 2024

This is pretty trivial, but it fixes some unknown types when using the library. Does it need a changelog entry?

@agronholm
Copy link
Owner

No, I don't think it warrants a changelog entry.

@agronholm agronholm merged commit 26e5869 into agronholm:master Aug 7, 2024
13 checks passed
@agronholm
Copy link
Owner

Thanks!

@injust
Copy link
Contributor Author

injust commented Aug 7, 2024

Ugh I missed one Callable because it was in a TypeAlias

#951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants