Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C17 Whales Morgan Adkisson #91

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Commits on Apr 6, 2022

  1. Oooops forgot to commit updates... updated vendor and item classes, p…

    …assing all tests in waves 01 and 02, finsihed wave assertions
    MorganAdkisson committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    110b272 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ea6bf5 View commit details
    Browse the repository at this point in the history
  3. use __str__ method to make Item return the default str 'Hello World!'…

    …, create Vendor method swap_item, and passed all tests
    
    in wave 03... refactored swap_items from nested if statements for Vendor and other Vendor to one if statement using 'and'
    MorganAdkisson committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    af510a3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ad5a8c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f7d2a11 View commit details
    Browse the repository at this point in the history
  6. create new classes (as new instances of Item) Clothing, Decor, Electr…

    …onics passing first three tests in wave 05
    MorganAdkisson committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3816427 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. wrote condition_description method in Item to be inherited by all ins…

    …tances, was able to pass all wave 05 tests except for test_items_have_condition_as_float - program stalling when it gets to this test
    MorganAdkisson committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    5032273 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b72885b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. conpleted swap_best_by_category and passed remaining tests in wave 06…

    …. Also made a temporary fix to Item class issue that was causing a stall in wave 05 tests (changed while loop). Still needs refactoring.
    MorganAdkisson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e0bde7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1f1eb2 View commit details
    Browse the repository at this point in the history
  3. optional enhancements: created get_newest_by_category helper function…

    … and swap_newest_by_category, created new test folder test_optional_enhancement to test additions
    MorganAdkisson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    f478e25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3bdc13f View commit details
    Browse the repository at this point in the history
  5. fixed bug in Vendor class that was keeping integration tests from run…

    …ning - the ussue was the use of mutable list as default inventory parameter
    MorganAdkisson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e3ad58e View commit details
    Browse the repository at this point in the history