C17 Whales Morgan Adkisson #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assing all tests in waves 01 and 02, finsihed wave assertions
…, create Vendor method swap_item, and passed all tests in wave 03... refactored swap_items from nested if statements for Vendor and other Vendor to one if statement using 'and'
…onics passing first three tests in wave 05
…tances, was able to pass all wave 05 tests except for test_items_have_condition_as_float - program stalling when it gets to this test
…. Also made a temporary fix to Item class issue that was causing a stall in wave 05 tests (changed while loop). Still needs refactoring.
… 100% code coverage
… and swap_newest_by_category, created new test folder test_optional_enhancement to test additions
…ning - the ussue was the use of mutable list as default inventory parameter
kaidamasaki
reviewed
Apr 22, 2022
Comment on lines
+4
to
+8
| def __init__(self, category="Clothing", condition=0.0, age=None): | ||
| self.category = category | ||
| self.condition = condition | ||
| self.age = age |
There was a problem hiding this comment.
category probably shouldn't be a parameter here since we don't want it to differ for different instances:
Suggested change
| """A child class of Item, representing aspects of an Item specific to Clothing""" | |
| def __init__(self, category="Clothing", condition=0.0, age=None): | |
| self.category = category | |
| self.condition = condition | |
| self.age = age | |
| """A child class of Item, representing aspects of an Item specific to Clothing""" | |
| def __init__(self, condition=0.0, age=None): | |
| self.category= "Clothing" | |
| self.condition = condition | |
| self.age = age |
Comment on lines
+13
to
+20
| 0: 'You should probably pass on this one...', | ||
| 1: 'Poor', | ||
| 2: 'Meh', | ||
| 3: 'Good', | ||
| 4: 'Great', | ||
| 5: 'Brand spankin new' | ||
| } |
There was a problem hiding this comment.
Using a dictionary for this is really clean. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.