Fixing calendar action in news creation #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2024
kumarpalsinh25
approved these changes
Aug 28, 2024
Comment on lines
192
to
198
| onTap: () async { | ||
| await ActerErrorDialog.show( | ||
| context: context, | ||
| error: e, | ||
| stack: s, | ||
| ); | ||
| }, |
Comment on lines
+5
to
+17
| static NewsReferencesType? fromStr(String typeStr) { | ||
| return values.asNameMap()[_toCamelCase(typeStr)]; | ||
| } | ||
| } | ||
|
|
||
| String _toCamelCase(String s) { | ||
| final words = s | ||
| .split('-') | ||
| .map((w) => | ||
| '${w.substring(0, 1).toUpperCase()}${w.substring(1).toLowerCase()}',) | ||
| .toList(); | ||
| words[0] = words[0].toLowerCase(); | ||
| return words.join(); |
There was a problem hiding this comment.
Not quite understand this code.
There was a problem hiding this comment.
it rewrites strings from things-named-like-this to thingsNamedLikeThis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2089 , I noticed that the way we construct the calendar-event-inline action is ... well, wrong. Instead of the typed
CalendarReferencewe were using theLinkRefwith some weirdtitleandidproperties as strings.This PR corrects that with fallback support for the types we have already sent/published. See the new one following by an old one:
calendar-events-proper-types.mp4
To the reviewer: