-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing better Error messages #2089
Conversation
Hey there 👋,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good initiative! Pretty help for end user experience and better bug management.
@@ -0,0 +1,40 @@ | |||
import 'package:acter/config/app_shell.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that this is only changes related to action function in separate file.
We have several screens where when one item fails to load (for whatever reason), we show plenty of ugly inline error messages that are almost impossible to do anything with. This is the first part of #2097 , which implements:
Dialog in Action with 404 on not found:
404-for-space.mp4
Sending Error and Stack via Bug Reporter:
bug-reporting-with-stack.mp4
This created the following report:
To the reviewers:
This introduces a new
ActerErrorDialog
andErrorPage
to the toolkit allowing any page to show neat looking errors (rather than ugly inlinedText('error msg')
ones) with the ability to report it as a bug or retry (by invalidating the provider, usually). For that the PR refactors the bug reporter into its own feature and refactors some of the pages to allow us to have automatic test confirm the error pages are shown and the retry is successfully done. The idea to expand all this over the entire system, including functional tests.