Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing better Error messages #2089

Merged
merged 14 commits into from
Aug 28, 2024
Merged

Showing better Error messages #2089

merged 14 commits into from
Aug 28, 2024

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Aug 22, 2024

We have several screens where when one item fails to load (for whatever reason), we show plenty of ugly inline error messages that are almost impossible to do anything with. This is the first part of #2097 , which implements:

  • For entire pages, a good looking error messages overlaying the loading content, with (where possible)
    • retry-button
    • bug reporting-button with support to sent the error and the stack trace
  • do something smart about the passed error (e.g. parsing 'not found' and show something less threatening)
  • SpaceDetailsPage, with tests
  • Pins
    • PinsList, with Tests
    • PinsDetails, with Tests

Dialog in Action with 404 on not found:

404-for-space.mp4

Sending Error and Stack via Bug Reporter:

bug-reporting-with-stack.mp4

This created the following report:

New bug reporter test

Number of logs: 0
Application: a3-dev
Labels: 
User-Agent: a3-dev/a3-dev
Version: DEV
description: with description field for more text now!
error: Space !asdgf not found
stack: 

To the reviewers:
This introduces a new ActerErrorDialog and ErrorPage to the toolkit allowing any page to show neat looking errors (rather than ugly inlined Text('error msg') ones) with the ability to report it as a bug or retry (by invalidating the provider, usually). For that the PR refactors the bug reporter into its own feature and refactors some of the pages to allow us to have automatic test confirm the error pages are shown and the retry is successfully done. The idea to expand all this over the entire system, including functional tests.

Copy link
Contributor

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

@gnunicorn gnunicorn added infrastructure smooth UX minor UI/UX problems and tasks labels Aug 22, 2024
@gnunicorn gnunicorn marked this pull request as ready for review August 23, 2024 12:05
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good initiative! Pretty help for end user experience and better bug management.

@@ -0,0 +1,40 @@
import 'package:acter/config/app_shell.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this is only changes related to action function in separate file.

app/lib/features/home/widgets/space_chip.dart Show resolved Hide resolved
app/lib/features/home/widgets/space_chip.dart Show resolved Hide resolved
app/lib/features/home/widgets/space_chip.dart Show resolved Hide resolved
@gnunicorn gnunicorn merged commit 0c65e6a into main Aug 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure smooth UX minor UI/UX problems and tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants