Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added safeguard #50

Merged
merged 1 commit into from
Aug 25, 2023
Merged

added safeguard #50

merged 1 commit into from
Aug 25, 2023

Conversation

FaroutYLq
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Require that no instruction should be actually used to simulate in the last 50ms of a chunk.

Potential risk: part of the instruction (anything in the last 50ms of a chunk) will NOT be simulated and seems as missing. We don't want to have this misunderstood by PEMA.

Can you briefly describe how it works?

Manually remove instructions in the last 50ms of each chunk.

        instructions = instructions[(instructions['time'] >= start) & 
                                    (instructions['time'] < end)] # Probably need safeguard here
                                    (instructions['time'] < end-NS_NO_INSTRUCTION_BEFORE_CHUNK_END)]

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Add an appropriate tag to this PR
  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@FaroutYLq FaroutYLq added the bug Something isn't working label Aug 25, 2023
@FaroutYLq FaroutYLq self-assigned this Aug 25, 2023
@FaroutYLq FaroutYLq marked this pull request as ready for review August 25, 2023 18:36
@FaroutYLq FaroutYLq merged commit 193c672 into main Aug 25, 2023
1 check failed
@FaroutYLq FaroutYLq deleted the timerange branch April 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant