Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safeguard in instruction times #39

Closed
FaroutYLq opened this issue Jul 28, 2023 · 1 comment
Closed

Safeguard in instruction times #39

FaroutYLq opened this issue Jul 28, 2023 · 1 comment
Assignees
@FaroutYLq
Labels
enhancement New feature or request

Comments

@FaroutYLq
Copy link
Collaborator

Describe the feature
Currently the instruction is pre-selected before chunking happens. However, it may be dangerous how we are doing it now. By the currently implementation, it could happen that the end of a pulse simulated goes beyond the chunk end time. We need additional safeguard. Maybe 1 FDT?

Expected behavior
Make an imaginary example of how the feature would work.

YOUR (PSEUDO) CODE GOES HERE

Proposed implementation

        instructions = instructions[(instructions['time'] >= start) & 
                                    (instructions['time'] < end - SAFEGUARD)]

Potential risk
Will a chunk be ever shorter than one FDT?

All italic comments can be removed from this template.
@FaroutYLq FaroutYLq added the enhancement New feature or request label Jul 28, 2023
@FaroutYLq FaroutYLq self-assigned this Jul 28, 2023
@FaroutYLq FaroutYLq mentioned this issue Aug 3, 2023
Merged
5 tasks
@FaroutYLq
Copy link
Collaborator Author

Seems working now #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FaroutYLq FaroutYLq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FaroutYLq