Skip to content
This repository has been archived by the owner on Aug 27, 2019. It is now read-only.

slug_update_spaceship would not update meta if $value evaluates to false #162

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

slug_update_spaceship would not update meta if $value evaluates to false #162

wants to merge 1 commit into from

Commits on Jul 27, 2016

  1. $value in slug_update_spaceship not set if it evalues to false 

    If you check for `! $value` in the validation in the example callback method `slug_update_spaceship`, a string value of `'0'` (or anything else that PHP evaluates to false) will be ignored and that post meta field will not be updated.

Since `'0'` might be a desired post meta value, I propose changing the validation on this line to instead check `isset` and ensure the string's length is >0.
    @TestValleySchool
    TestValleySchool authored Jul 27, 2016
    Configuration menu
    Copy the full SHA
    21a4f22 View commit details
    Browse the repository at this point in the history