This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
slug_update_spaceship would not update meta if $value evaluates to false
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you check for `! $value` in the validation in the example callback method `slug_update_spaceship`, a string value of `'0'` (or anything else that PHP evaluates to false) will be ignored and that post meta field will not be updated. Since `'0'` might be a desired post meta value, I propose changing the validation on this line to instead check `isset` and ensure the string's length is >0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you check for
! $valuein the validation in the example callback methodslug_update_spaceship, a string value of'0'(or anything else that PHP evaluates to false) will be ignored and that post meta field will not be updated.Since
'0'might be a desired post meta value, I propose changing the validation on this line to instead checkissetand ensure the string's length is >0.