Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuexのstoreの呼び出しをリテラル引数からDot記法へ: src/store/ #2327

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

Segu-g
Copy link
Member

@Segu-g Segu-g commented Oct 26, 2024

内容

store/フォルダ内のdispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。

  • src/store/index.ts
  • src/store/audioPlayer.ts
  • src/store/project.ts
    を対応しています。

また、withProgressDotNotationcreateDotNotationPartialStore といったDotNotationが付いた名前を元に戻しています。

関連 Issue

スクリーンショット・動画など

その他

@Segu-g Segu-g requested a review from a team as a code owner October 26, 2024 17:28
@Segu-g Segu-g requested review from Hiroshiba and removed request for a team October 26, 2024 17:28
@Segu-g Segu-g marked this pull request as draft October 26, 2024 17:48
@Segu-g Segu-g changed the title vuexのstoreの呼び出しをリテラル引数からDot記法へ: src/store/index.ts vuexのstoreの呼び出しをリテラル引数からDot記法へ: src/store/ Oct 26, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

綺麗に型が繋がっていて気持ちいいですね!!!!
色々考えて作ってくださったからだと思います、ありがとうございます!!!

@Hiroshiba Hiroshiba merged commit ffc315c into VOICEVOX:main Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants