Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuexのstoreの呼び出しをリテラル引数からDot記法へ: components/Menu #2329

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

Segu-g
Copy link
Member

@Segu-g Segu-g commented Oct 26, 2024

内容

components/Menu/フォルダ内のdispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。

  • src/components/Menu/MenuBar/MenuBar.vue
  • src/components/Menu/MenuBar/MinMaxCloseButtons.vue
  • src/components/Menu/MenuBar/TitleBarEditorSwitcher.vue
    を対応しています。

関連 Issue

スクリーンショット・動画など

その他

dispatch([\s\n]"([A-Z_])",?
actions.$1(
と正規表現で置換してその後眼力チェックしています。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit e49d70e into VOICEVOX:main Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants