Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Storybookにテーマが適用されるように #2299
Add: Storybookにテーマが適用されるように #2299
Changes from 8 commits
d44ea2e
26edd56
380be92
0062235
c197bf6
d9a7d8f
36f455d
5bab242
6cad328
40e46ac
160e85e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lightを上にして、light/darkのexportを外させていただきます!
意図してexportしているのかわからないので、YAGNI原則に従って必要なときにexportするのが良いかなぁと。
(若干自信なし)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storeの
SET_AVAILABLE_THEMES
残すのありだと思います!ただここの関数はバックエンドの設定をフロント側に持ってくる部分なのですが、若干意図不明なコードになったかもですね!
ということで、カスタムテーマなどで動的に増やすことも見据えて残してあることをコメントで書いとこうと思います 🙏