Add: Storybookにテーマが適用されるように #2299
Merged
+95
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
[update snapshots]
Hiroshiba
reviewed
Oct 19, 2024
Hiroshiba
reviewed
Oct 19, 2024
Hiroshiba
approved these changes
Oct 20, 2024
src/domain/theme/index.ts
Outdated
There was a problem hiding this comment.
lightを上にして、light/darkのexportを外させていただきます！
意図してexportしているのかわからないので、YAGNI原則に従って必要なときにexportするのが良いかなぁと。
（若干自信なし）
| @@ -79,7 +80,7 @@ export const settingStore = createPartialStore<SettingStoreTypes>({ | |||
| }); | |||
|
|
|||
| mutations.SET_AVAILABLE_THEMES({ | |||
| themes: await window.backend.getAvailableThemes(), | |||
| themes, | |||
| }); | |||
There was a problem hiding this comment.
StoreのSET_AVAILABLE_THEMES残すのありだと思います！
ただここの関数はバックエンドの設定をフロント側に持ってくる部分なのですが、若干意図不明なコードになったかもですね！
ということで、カスタムテーマなどで動的に増やすことも見据えて残してあることをコメントで書いとこうと思います 🙏
|
あ、多分今のままマージするとmainのCIが落ちると思います（TextDialogのsnapshotが更新されてないのでテストが落ちる） |
|
@sevenc-nanashi おっとなるほどです！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Storybookにテーマが適用されるようにします。
関連 Issue
（なし）
スクリーンショット・動画など
その他
VRTにダークテーマも付けて良いかも