feat(vkui): mv @vkontakte/icons to deps #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Переносим иконки в зависимости
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit af503b6 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af503b6:
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5718 +/- ##
==========================================
- Coverage 81.93% 81.93% -0.01%
==========================================
Files 296 296
Lines 9780 9779 -1
Branches 3102 3102
==========================================
- Hits 8013 8012 -1
Misses 1767 1767
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eugpoloz
approved these changes
Aug 30, 2023
SevereCloud
deleted the
SevereCloud/feat/vkui/mv-@vkontakte/icons-to-deps
branch
inomdzhon
added a commit
that referenced
this pull request
Nov 30, 2023
h2. Описание Удаляем зависимость и его упоминания везде, кроме `integrations_vk_mini_apps.md`. h2. Изменения Также удалил `@vkontakte/icons` из инструкции по установке (см. #5718).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Переносим иконки в зависимости