Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rm legacy vk-bridge #6170

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Nov 30, 2023


  • Гайд миграции

Описание

Удаляем зависимость и его упоминания везде, кроме integrations_vk_mini_apps.md.

Изменения

Также удалил @vkontakte/icons из инструкции по установке (см. #5718).

@inomdzhon inomdzhon requested a review from a team as a code owner November 30, 2023 05:54
Copy link
Contributor

size-limit report 📦

Path Size
JS 337.06 KB (0%)
JS (gzip) 102.68 KB (0%)
JS (brotli) 84.97 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 260.07 KB (0%)
CSS (gzip) 33.82 KB (0%)
CSS (brotli) 27.42 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bf88c3:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 9bf88c3

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1831867) 79.99% compared to head (9bf88c3) 79.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6170   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files         311      311           
  Lines        9784     9784           
  Branches     3285     3285           
=======================================
  Hits         7827     7827           
  Misses       1957     1957           
Flag Coverage Δ
unittests 79.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inomdzhon inomdzhon merged commit 84eac04 into master Nov 30, 2023
27 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issue6169/feat/rm-vk-bridge-react branch November 30, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE]: удалить зависимость @vkontakte/vk-bridge
3 participants