Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Sort functionality from SongMenu #869

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Remove Sort functionality from SongMenu #869

merged 1 commit into from
Jul 21, 2024

Conversation

DeinAlptraum
Copy link
Contributor

@DeinAlptraum DeinAlptraum commented Jul 14, 2024 •
edited
Loading

Resolves #862

I hope I found all places. This leaves a gap in the menu, that is just skipped over when navigating with the arrow keys

barbeque-squared
barbeque-squared approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@barbeque-squared barbeque-squared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes less code than I thought/was hoping it could remove, but still, we need to start somewhere in shedding features for the 0.1% and this is as good a place as any. Works fine!

@barbeque-squared barbeque-squared merged commit 46cf3f1 into UltraStar-Deluxe:master Jul 21, 2024
4 checks passed
@DeinAlptraum DeinAlptraum deleted the remove-sort branch July 21, 2024 12:25
@barbeque-squared barbeque-squared mentioned this pull request Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbeque-squared barbeque-squared barbeque-squared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reenable sort menu in song selection
2 participants
@DeinAlptraum @barbeque-squared