Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on the highscores/top5 screen, only show the highest score per player #725

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

on the highscores/top5 screen, only show the highest score per player #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/base/UDataBase.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,12 +514,15 @@ procedure TDataBaseSystem.ReadScore(Song: TSong);
TableData := nil;
try
// Search Song in DB
// TODO: isn't the whole filter completely unnecessary with the GROUP BY?
// if yes, why not just do a much simpler query for each difficulty? can also add LIMIT that way?
TableData := ScoreDB.GetUniTable(
'SELECT [Difficulty], [Player], [Score], [Date] FROM [' + cUS_Scores + '] ' +
'WHERE [SongID] = (' +
'SELECT [ID] FROM [' + cUS_Songs + '] ' +
'WHERE [Artist] = ? AND [Title] = ? ' +
'LIMIT 1) ' +
'GROUP BY [Difficulty], [Player] HAVING MAX([Score]) ' +
'ORDER BY [Score] DESC;', //no LIMIT! see filter below!
[Song.Artist, Song.Title]);

Expand Down