Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on the highscores/top5 screen, only show the highest score per player #725

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barbeque-squared
Copy link
Member

…. and also adds a TODO because the filter is useless now? (not that it did anything to begin with...)
I'm not interest in seeing how often a certain player has set a good score, I'm interested in seeing how it compares to other players. I've been using this since August 2022 and is really nice.

what this PR does in pictures:
before:
screenshot0046

after:
screenshot0048

…. also adds a TODO because the filter is useless now? (not that it did anything to begin with...)
@barbeque-squared
Copy link
Member Author

As commented by servok in Discord:

In USDX 2020.4.0, we use the "1 Highscore per Player"-option for years now, and it's very good. You still see if you were better than your highscore. There is an option under options-advanced saying "Höchstpunktzahlen: Spieler" or "Höchstpunktzahlen: Alle", switching between the alternatives

The score code even does something with this option, but it's not very intuitive. Until I was pointed to it, I wasn't even aware of this option. Yeah this PR is invalid, I'll change to to WIP for now and close it once I have a PR that refactors this whole bit of code, as well as how the setting is stored (it's currently a number and apparently "1" is the Player option -- this should really be an enum)

Still leaves the debate of what should be the default (imo "Player") but we'll get to that once this mess is gone.

@barbeque-squared barbeque-squared marked this pull request as draft August 17, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant