Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushing git demo #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pushing git demo #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{name = "Jaap Singh"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the first ever PR! (at least what GitHub told me)

Valid JSON file is tricky!

  • The key part (left hand side) has to be quoted, and the key, value delimiter is colon :. It would look something like this:
{
    "thisKey" : "thatValue"
}
  • Also move this file under data folder.