Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pushing git demo #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pushing git demo #21

wants to merge 1 commit into from

Conversation

j-s-457
Copy link

@j-s-457 j-s-457 commented Oct 20, 2019

No description provided.

@j-s-457 j-s-457 closed this Oct 20, 2019
@j-s-457 j-s-457 reopened this Oct 20, 2019
MrMinos
MrMinos requested changes Oct 20, 2019
View reviewed changes
file.json
@@ -0,0 +1 @@
{name = "Jaap Singh"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the first ever PR! (at least what GitHub told me)

Valid JSON file is tricky!

  • The key part (left hand side) has to be quoted, and the key, value delimiter is colon :. It would look something like this:
{
    "thisKey" : "thatValue"
}
  • Also move this file under data folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrMinos MrMinos MrMinos requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-s-457 @MrMinos