Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse_mode for aiogram 3.4.1 #29

Closed
wants to merge 1 commit into from
Closed

Fix parse_mode for aiogram 3.4.1 #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sulguk/aiogram_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,4 +115,6 @@ def _is_parse_mode_supported(self, method: Any, bot: Bot) -> bool:
parse_mode = getattr(method, "parse_mode", "")
if parse_mode is UNSET_PARSE_MODE:
parse_mode = bot.parse_mode
if isinstance(parse_mode, type(UNSET_PARSE_MODE)):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it differ from if parse_mode is UNSET_PARSE_MODE?

parse_mode = bot.default.parse_mode
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail on older versions. We need either specify new version in requirements or find workaround

return parse_mode == SULGUK_PARSE_MODE
Loading