Fix parse_mode for aiogram 3.4.1 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishka17
reviewed
Mar 8, 2024
| @@ -115,4 +115,6 @@ def _is_parse_mode_supported(self, method: Any, bot: Bot) -> bool: | |||
| parse_mode = getattr(method, "parse_mode", "") | |||
| if parse_mode is UNSET_PARSE_MODE: | |||
| parse_mode = bot.parse_mode | |||
| if isinstance(parse_mode, type(UNSET_PARSE_MODE)): | |||
There was a problem hiding this comment.
does it differ from if parse_mode is UNSET_PARSE_MODE?
Tishka17
reviewed
Mar 8, 2024
| @@ -115,4 +115,6 @@ def _is_parse_mode_supported(self, method: Any, bot: Bot) -> bool: | |||
| parse_mode = getattr(method, "parse_mode", "") | |||
| if parse_mode is UNSET_PARSE_MODE: | |||
| parse_mode = bot.parse_mode | |||
| if isinstance(parse_mode, type(UNSET_PARSE_MODE)): | |||
| parse_mode = bot.default.parse_mode | |||
There was a problem hiding this comment.
This will fail on older versions. We need either specify new version in requirements or find workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in issues 28 related to parse_mode in aiogram 3.4.1. The fixes support earlier versions of aiogram!