fix obs and var defaults to return all values if none spec'd #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
approved these changes
Oct 29, 2024
sgillies
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
@spencerseale Just a bug fix, yes? No extra documentation needed?
|
@sgillies yes just bug fix. I want to make sure @aaronwolen reviews prior to merge. There may be some historical context on why we do the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting as empty list if
Nonespecified forobs_attrsand/orvar_attrsresults in anAnnDatanot having all attributes in obs/var dataframes.