Full refactor of use_*_file

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: golem
 Title: A Framework for Robust Shiny Applications
-Version: 0.5.1
+Version: 0.5.1.9001
 Authors@R: c(
     person("Colin", "Fay", , "[email protected]", role = c("cre", "aut"),
            comment = c(ORCID = "0000-0001-7343-1846")),

NEWS.md

@@ -1,5 +1,17 @@
 > Notes: the # between parenthesis refers to the related issue on GitHub, and the @ refers to an external contributor solving this issue.
 
+# golem 0.5.1 to 0.6.0
+
+## Breaking change
+
+- The use_*_files now fail when:
+  - The directory where the user tries to add the file doesn't exist. `{golem}` used to try to create the directory but that's not the function job — use_*_file functions should only be there to add file (Singe responsabily  )
+  - The file that the user tries to create already exists
+
+## Internal changes
+
+- Full refactoring of the use_*_files functions that now all share the same behavior
+
 # golem 0.5.1
 
 * Hotfixing a bug with utils_download_file (#1168)

R/after_creation_msg.R

@@ -123,21 +123,16 @@ file_created_dance <- function(
   dir,
   name,
   open_file,
-  open_or_go_to = TRUE,
   catfun = cat_created
 ) {
   catfun(where)
 
-  fun(pkg, dir, name)
+  fun(pkg, dir, basename(where))
 
-  if (open_or_go_to) {
-    open_or_go_to(
-      where = where,
-      open_file = open_file
-    )
-  } else {
-    return(invisible(where))
-  }
+  open_or_go_to(
+    where = where,
+    open_file = open_file
+  )
 }
 
 file_already_there_dance <- function(

R/boostrap_cli.R

@@ -43,3 +43,12 @@ cli_cli_alert_info <- function(...) {
     )
   })
 }
+
+cli_cli_abort <- function(message) {
+  if (rlang::is_installed("cli")) {
+    cli::cli_abort(message = message, call = NULL)
+  } else {
+    stop(message)
+  }
+}
+