Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full refactor of use_*_file #1170

Merged
merged 34 commits into from
Aug 27, 2024
Merged

Full refactor of use_*_file #1170

merged 34 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. refactor: split use_external/internal, and wrapped download/copy to f… 

    …unctions
    @ColinFay
    ColinFay committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c36f946 View commit details
    Browse the repository at this point in the history

  2. feat: checking the url extension now throws an error if the extension… 

    … is not correct
    @ColinFay
    ColinFay committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    95735eb View commit details
    Browse the repository at this point in the history

  3. refactor: use build_name inside external

    @ColinFay
    ColinFay committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    26e931f View commit details
    Browse the repository at this point in the history

  4. refactor: split into two files

    @ColinFay
    ColinFay committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8c5910f View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. feat: the function creation files now fail if the dir doesn't not exist 

    Instead of trying to create the dir,
the function creation files now fail
if the dir doesn't exist.
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    82b5508 View commit details
    Browse the repository at this point in the history

  2. feat: use_*_files now throws an error if the file already exists

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b3a1320 View commit details
    Browse the repository at this point in the history

  3. refactor: checks are performed at the top of the function 

    and always in the same order
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c24e07e View commit details
    Browse the repository at this point in the history

  4. fix: define name before

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7722dfb View commit details
    Browse the repository at this point in the history

  5. refactor: using basename of where instead of name in file_created_dance

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    105ea66 View commit details
    Browse the repository at this point in the history

  6. refactor: merging check_file_exists and download_external

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b8f9e15 View commit details
    Browse the repository at this point in the history

  7. refactor: merged check_file_exists and copy_internal_file

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    84cf0ae View commit details
    Browse the repository at this point in the history

  8. refactor: renaming params

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    4b590f2 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dev' into cp-1022

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5490a56 View commit details
    Browse the repository at this point in the history

  10. refactor: merging check & download

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9ac5ede View commit details
    Browse the repository at this point in the history

  11. refactor: merged perform_checks_and_download_if_everything_is_ok & fi… 

    …le_created_dance
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    dbd3acf View commit details
    Browse the repository at this point in the history

  12. refactor: merged perform_check and file_created dance 

    in use_files_internal
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    598fe99 View commit details
    Browse the repository at this point in the history

  13. refactor: where_to_download moved inside the function

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    23905aa View commit details
    Browse the repository at this point in the history

  14. refactor: where_to_download moved inside the function

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    461bb5a View commit details
    Browse the repository at this point in the history

  15. fix: correct param name

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    149ce19 View commit details
    Browse the repository at this point in the history

  16. refactor: path_abs as input

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    75af1ba View commit details
    Browse the repository at this point in the history

  17. refactor: name is now built inside perform_checks_and_download_if_eve… 

    …rything_is_ok
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0a4dcab View commit details
    Browse the repository at this point in the history

  18. refactor: moving setwd() inside perform_checks_and_download_if_everyt… 

    …hing_is_ok
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    cbdc7f3 View commit details
    Browse the repository at this point in the history

  19. fix: correct params in build_name

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c16f135 View commit details
    Browse the repository at this point in the history

  20. refactor: path_abs(dir) as param

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d0d3276 View commit details
    Browse the repository at this point in the history

  21. feat: changed extension error message

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2165bf9 View commit details
    Browse the repository at this point in the history

  22. test: update snapshot

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ccfd1d1 View commit details
    Browse the repository at this point in the history

  23. refactor: where_to_copy_to is inside perform_checks_and_copy_if_every… 

    …thing_is_ok
    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    88c58f6 View commit details
    Browse the repository at this point in the history

  24. refactor: name & setwd now in wrapper fun

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f835ffc View commit details
    Browse the repository at this point in the history

  25. feat: deprecate the dir_create param

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5b331d5 View commit details
    Browse the repository at this point in the history

  26. refactor: rm name from file_create_dance in use_file

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    598fc7f View commit details
    Browse the repository at this point in the history

  27. refactor: rm the open_or_go_to arg from file_created_dance

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0480655 View commit details
    Browse the repository at this point in the history

  28. Merge branch 'dev' into cp-1022

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    86328b3 View commit details
    Browse the repository at this point in the history

  29. doc: news update

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5801c0f View commit details
    Browse the repository at this point in the history

  30. doc: forgot to push the man

    @ColinFay
    ColinFay committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    13376fe View commit details
    Browse the repository at this point in the history