Fix fast seek overlay arc not correctly centered #7893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triallax
added
bug
TobiGr
reviewed
Feb 18, 2022
This happened in fullscreen player: while play-pause, brightness, volume, ... buttons were correctly centered in the app UI, the fast seek overlay was centered in the system UI, causing a mismatch between the two that looked ugly
TobiGr
force-pushed
the
regression-arc
branch
from
e501fbf
to
ba15fc8
Compare
TobiGr
approved these changes
Feb 18, 2022
|
Kudos, SonarCloud Quality Gate passed! |
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR makes sure that the fast seek overlay arcs share the same paddings as other controls (such as play-pause, brightness, volume, ...). The paddings are being set by the code and are "caused" by the system navigation bar. Play-pause, brightness, volume, ... buttons were correctly centered in the app UI (i.e. all of the screen excluding the navigation bar), while the fast seek overlay was centered in the system UI (i.e. the whole screen), causing a mismatch between the two that looked ugly, as seen in #7731. My way of fixing it might not be the best, as the arc is now not drawn under the system navigation bar anymore (see After screenshot below), but I just wanted to create a PR, I will try to improve it properly later today or tomorrow (though I think the current state is already acceptable).
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence