Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play/Pause buttons are not centered in fullscreen mode / Arc size of double tap gestures is not the same #7731

Closed
4 tasks done
SameenAhnaf opened this issue Jan 31, 2022 · 4 comments · Fixed by #7893
Closed
4 tasks done
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jan 31, 2022

Checklist

Steps to reproduce the bug

View a video (with a cosshair) in fullscreen mode.
Or use the double tap gesture.

Actual behavior

Note that the play/pause button are not centered.
There's a striking difference in arc size. Double tap to rewind tends to smudge with Pause icon.

Expected behavior

The play/pause button are not centered.
Size of the arcs should be the same. Don't smudge the arc with Pause icon to keep the UI a little more clean.

Screenshots/Screen recordings

Rewind Gesture Fast Forward Gesture

Further examples with a crosshair from a minecraft video:

Demo1 Demo2
grafik grafik

Portrait mode works as expected:
grafik

@SameenAhnaf SameenAhnaf added the bug Issue is related to a bug label Jan 31, 2022
@triallax triallax added the GUI Issue is related to the graphical user interface label Feb 1, 2022
@litetex
Copy link
Member

litetex commented Feb 7, 2022

The arc size is perfect.
The buttons are off-centered (because of the system menu/buttons) inside the full screen mode and that is the problem.

I noticed that while I watched video which have a crosshair, e.g.:

grafik
grafik
grafik

@opusforlife2
Copy link
Collaborator

@litetex Then could you update the title and description, please?

@litetex litetex changed the title Arc size of double tap gestures is not the same Play/Pause buttons are not centered in fullscreen mode Feb 12, 2022
@litetex litetex changed the title Play/Pause buttons are not centered in fullscreen mode Play/Pause buttons are not centered in fullscreen mode / Arc size of double tap gestures is not the same Feb 12, 2022
@litetex
Copy link
Member

litetex commented Feb 12, 2022

Done

@TobiGr
Copy link
Member

TobiGr commented Feb 18, 2022

Fixed by #7893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants