-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "add to playlist" option in the share menu #7194
Add a "add to playlist" option in the share menu #7194
Conversation
@KalleStruik However I applied some fixes regarding the underlying code. What I did:
I also added a little hint/toast-notification that adding to the playlist may take a moment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one little problem:
The cursor seems to have the wrong color in the "New Playlist"/CreatePlaylistDialog.
Looks like the "colorAccent" is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected 👍
LGTM
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
While I can appreciate that my quick typing asking to pull #5850 ahead of this might seem off-topic and out of left field. They are very similar in code that is being touched and purpose for why this feature is being added. #5850 is enqueue in the background restored which was a feature up until like version 19. |
This comment has been minimized.
This comment has been minimized.
You highlighted four things I said and I can explain. Binge watching similar videos is a breeze is what the old enqueue functionality allowed. The last part was a gripe to fix what was broken before trying to add new features. 5850 is the consolidation of several tickets which all had the same root cause of removing the queue. Is there something inherently wrong with #5850 that prevents it from being reviewed and pushes this PR ahead? |
#5850 already has conflicts: And yeah that happens. We rebase the issue, fix the conflicts and everything will be fine.
???
#5850 handles issue #4779 which is an enhancement/new feature. If it was so in an old version then it seems to have been removed on purpose or was a not recognized... Update: That's even written in #4779 "Until newPipe 0.20.2, while playing a video in background or pop-up mode, sharing another video from others apps to newPipe would enqueue them directly. However this is changing in the upcoming release because it was determined to be bad UX #4562..."
It's not reviewed and I don't want to rebase and review an already okay and up-to-date PR (this one). I'm merging this now as I can see no logical arguments that are speaking against that. |
[!] Before this can be merged, there is a small theming issue that needs to be fixed. When creating a new playlist from the share dialog it uses the wrong color for the buttons (See screenshot 4). I have been unable to find the cause of this bug, so any help in fixing it is appreciated.FixedWhat is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
When no playlists exist:
When a playlist exists:
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence