Improve playlist dialogs, use only one layout

[Stypox]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Use the same class and the same layout both to append an item to a local playlist and to choose a local/remote playlist tab. The resulting PlaylistDialog class is the result of a merge between the old local.dialog.Playlist*Dialog and SelectPlaylistFragment classes. In particular:

• The custom adapter found in SelectPlaylistFragment has been kept, to allow for both local and remote items to exist in the list
• The correct state saving behaviour is taken from local.dialog.PlaylistDialog
  Fixes ui issues with the select playlist tab dialog, which didn't show uploaders and stream counts, looked strange and had double title on Android 4.4.

Depends on

#3982 (due to bug report fix)

Testing apk

Tested on emulated Android 4.4 and device Android 7.0.
app-debug.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[TobiGr]

I did not test if this is also in the current version, but the info should be aligned properly.

[Stypox]

@TobiGr that's unrelated from this PR, let's create an issue

[ghost]

Add to playlist button make app crash :(
https://i.imgur.com/VQEVqqa.jpg
I paste an "log" yes "log" because is empty.

Exception

• User Action: ui error
• Request: App crash, UI failure
• Content Country: IT
• Content Language: it-IT
• App Language: it_IT
• Service: none
• Version: 0.19.6
• OS: Linux Android 4.4.4 - 19

Crash log

---

I think Log have problem

[Stypox]

Hi @domiuns , thank you for testing ;-)
Unfortunately I am unable to reproduce on the emulator. Could you point out the exact steps leading to the crash since opening the app?

Since you have Android 4.4, would you like to join the testers (@mentioned in PRs needing tests on old devices)? If so, please add yourself here: https://github.com/TeamNewPipe/NewPipe/wiki/Testers

[ghost]

Hi @Stypox the app crash happens in all sections, I just press add to the playlist (I loaded the zip file with the old configurations) but I also tried with a clean installation and the app continues to crash. try the feed section or the trend section.

I have add my "name" to the tester list, i want help this project :) i'm not a programmer but I want to help you as much as I can.

[Stypox]

@domiuns in #3982 I fixed the problem you had with missing stack trace. Could you test this new apk and provide me the bug report, which should now be non-empty?
app-debug.zip

[litetex]

@Stypox
Any progress here?
Or should we close this?

[Stypox]

This would have to be redone from scratch, as there have been changes in the meantime. Closing it

[litetex]

Some cleanup will be done with #7194