New streams notifications #2335

Koitharu · 2019-05-09T18:06:41Z

Checking and notifying about new streams from subscriptions
Closes #719 closes #1086

I carefully read the contribution guidelines and agree to them.

Redirion · 2019-05-10T07:05:45Z

cool!
a nice addition to that feature would be to be able to select the channels for which I want to receive notifications similar to the "bell" feature in Youtube.

Koitharu · 2019-05-10T09:33:53Z

Ok, I'll do it. Also I have a question to the community: how is better to mark, which streams are already "known" at channel?

Stypox · 2019-05-10T19:19:14Z

I think a video should be marked as "known" after it has been opened (in any way: background, info, popup...). An option to manually mark a video as known would be useful, too, then.

ShareASmile · 2020-03-29T06:56:53Z

Ahh.. Waiting for live stream notifications for so long..

Edit:
Now as proper feed implementation by
#2309
has already taken place, this new stream notification should be next big feature to make into this marvellous app The NewPipe.

Flam3z · 2020-04-02T09:50:36Z

Definitely would love to see this feature as the next big thing as well :)

Koitharu · 2020-04-11T18:27:55Z

What about merging this PR? I`ll resolve conflicts and migrate to androidx WorkManager

wb9688 · 2020-04-12T13:40:31Z

@nv95: That's good. Please use vector drawables for the new icons though (and test that it doesn't cause a crash on Android API 19). Note that there were some major changes to the subscriptions in v0.19.0.

Imho the notifications should be opt-in though.

B0pol · 2020-05-10T11:09:14Z

@nv95: That's good. Please use vector drawables for the new icons though (and test that it doesn't cause a crash on Android API 19). Note that there were some major changes to the subscriptions in v0.19.0.

Imho the notifications should be opt-in though.

I don't know if it was the case but it's now opt-in

B0pol

I've seen you have to subscribe to notifications via settings -> notification -> channels

Please add the notification button in channel header too, it's way more user-friendly.

And add a subscribe to all button in notification settings.

B0pol · 2020-05-10T19:09:43Z

Also, why is it leading to channel info instead of video info?

Stypox

Some icons unfortunately can't be converted to vector drawables because they are used in notifications, which require bitmaps. But there are still some issues with icons.

_{Btw @wb9688 how were you able to rebase this while being sure not to create problems even in mid commits? I tried a while ago, but there were so many conflicting commits that trying to understand what the author was doing in each one of them (i.e. the purpose of every piece of code) seemed impossible}

Stypox · 2020-05-18T07:49:30Z

app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java

@@ -532,4 +591,10 @@ public void setTitle(final String title) {
            headerTitleView.setText(title);
        }
    }
+
+    private boolean isNotificationsEnabled() {


Maybe it would be better to put this in the NotificationHelper class, so that is can then be accessed from anywhere. In the future we could e.g. want to long-press on a subscription to see the option for notifications and this function would be needed.

app/src/main/res/values/strings.xml

app/src/main/res/xml/notifications_settings.xml

Stypox · 2020-05-18T08:15:17Z

app/src/main/java/org/schabi/newpipe/notifications/NotificationHelper.java

+        final NotificationCompat.Builder builder = new NotificationCompat.Builder(context,
+                context.getString(R.string.streams_notification_channel_id));
+        builder.setContentTitle(String.format("%s • %s", data.getName(), summary));
+        builder.setContentText(data.getText());
+        builder.setNumber(data.getSize());
+        builder.setBadgeIconType(NotificationCompat.BADGE_ICON_LARGE);
+        builder.setPriority(NotificationCompat.PRIORITY_DEFAULT);
+        builder.setSmallIcon(R.drawable.ic_stat_newpipe);
+        builder.setLargeIcon(BitmapFactory.decodeResource(context.getResources(),
+                R.drawable.ic_newpipe_triangle_white));
+        builder.setColor(ContextCompat.getColor(context, R.color.ic_launcher_background));
+        builder.setColorized(true);
+        builder.setAutoCancel(true);
+        builder.setCategory(NotificationCompat.CATEGORY_SOCIAL);


If this is a Builder, can't you do this? Also, maybe create the style beforehand, so that you can add the .setStyle() and .setContentIntent() at the end

Suggested change

final NotificationCompat.Builder builder = new NotificationCompat.Builder(context,

context.getString(R.string.streams_notification_channel_id));

builder.setContentTitle(String.format("%s • %s", data.getName(), summary));

builder.setContentText(data.getText());

builder.setNumber(data.getSize());

builder.setBadgeIconType(NotificationCompat.BADGE_ICON_LARGE);

builder.setPriority(NotificationCompat.PRIORITY_DEFAULT);

builder.setSmallIcon(R.drawable.ic_stat_newpipe);

builder.setLargeIcon(BitmapFactory.decodeResource(context.getResources(),

R.drawable.ic_newpipe_triangle_white));

builder.setColor(ContextCompat.getColor(context, R.color.ic_launcher_background));

builder.setColorized(true);

builder.setAutoCancel(true);

builder.setCategory(NotificationCompat.CATEGORY_SOCIAL);

final NotificationCompat.Builder builder = new NotificationCompat.Builder(context,

context.getString(R.string.streams_notification_channel_id))

.setContentTitle(String.format("%s • %s", data.getName(), summary))

.setContentText(data.getText())

.setNumber(data.getSize())

.setBadgeIconType(NotificationCompat.BADGE_ICON_LARGE)

.setPriority(NotificationCompat.PRIORITY_DEFAULT)

.setSmallIcon(R.drawable.ic_stat_newpipe)

.setLargeIcon(BitmapFactory.decodeResource(context.getResources(),

R.drawable.ic_newpipe_triangle_white))

.setColor(ContextCompat.getColor(context, R.color.ic_launcher_background))

.setColorized(true)

.setAutoCancel(true)

.setCategory(NotificationCompat.CATEGORY_SOCIAL);

Stypox · 2020-05-18T08:16:53Z

app/src/main/java/org/schabi/newpipe/notifications/NotificationHelper.java

+        builder.setCategory(NotificationCompat.CATEGORY_SOCIAL);
+        final NotificationCompat.InboxStyle style = new NotificationCompat.InboxStyle();
+        for (StreamInfoItem o : data.getStreams()) {
+            style.addLine(o.getName());


Question: why are stream names shown both in builder.setContentText(data.getText()); and here?

builder.setContentText is used for collapsed notification, style applied for expanded

app/src/main/java/org/schabi/newpipe/notifications/SubscriptionUpdates.kt

Stypox · 2020-05-18T09:25:43Z

app/src/main/java/org/schabi/newpipe/settings/NotificationsSettingsFragment.kt

+    }
+
+    override fun onSharedPreferenceChanged(sharedPreferences: SharedPreferences?, key: String?) {
+        val ctx = context ?: return


This usage of ctx looks a bit strange, though I don't know if this piece of code can be reworded

Stypox · 2020-05-18T09:35:05Z

app/src/main/java/org/schabi/newpipe/settings/NotificationsSettingsFragment.kt

+
+    private fun updateSubscriptions(list: List<SubscriptionEntity>) {
+        var notified = 0
+        for (o in list) {


Instead of calling it o and list, I think subscription and subscriptions would be better names

Stypox · 2020-05-18T09:41:20Z

app/src/main/java/org/schabi/newpipe/settings/notifications/NotificationsConfigAdapter.kt

+
+    fun update(newData: List<SubscriptionEntity>?) {
+        dataSet.clear()
+        dataSet.addAll(newData!!)


Why make it nullable and then assert it is not null?

Stypox · 2020-05-18T09:46:31Z

app/src/main/java/org/schabi/newpipe/settings/notifications/NotificationsConfigAdapter.kt

+            val icon = AnimatedVectorDrawableCompat.create(
+                    itemView.context,
+                    if (mode == NotificationMode.DISABLED) {
+                        R.drawable.av_notification_off
+                    } else {
+                        R.drawable.av_notification_on
+                    }
+            ) ?: return null
+            icon.setTint(ThemeHelper.resolveColorFromAttr(
+                    itemView.context, android.R.attr.textColorPrimary
+            ))


You should use an attr icon here, so that it can be styled according to themes automatically. Also, why is the name of those icons not ic_notification_on_white_24dp? So, in the end you should have 4 icons (ic_notification_on_white_24dp, ic_notification_on_black_24dp, ic_notification_off_white_24dp, ic_notification_off_black_24dp)

What reasons to use different icons if we can use one icon with tint?

Stypox

I pushed a commit making some small changes. The code looks good, now it just needs testing. I will be leaving notifications on on my phone with my subscriptions database for a while.

app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationWorker.kt

Stypox · 2022-02-25T18:21:14Z

I will be leaving notifications on on my phone with my subscribers database for a while.

After two days everything still seems to be up and running

Removed some non-translatable strings and just hardcoded them in the code, like it's being done for other string separators. This also deduplicates some code by using Localization. Used some Kotlin feature to reduce code.

It never kicked in since we are never returning a retry() Result, but always either success() or failure() (see createWork() function). Also, there is already a default (exponential backoff starting from 30 seconds), so no need to override it.

sonarcloud · 2022-03-19T21:57:52Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

Stypox

Merged and fixed conflicts
Added a commit removing the backoff criteria completely
Added a commit that makes the "Player notification" entry searchable in settings. I don't mean the settings contained within player notification, as those were already searchable, but rather just the button in appearance settings that brings you to player notification settings: it is now searchable.
I tested for a few days on my phone (a couple of weeks ago) and notifications worked fine.
I tested again now on the API 19 and API 30 emulators and notifications worked. Also other things this PR touched worked, such as settings, subscribing to channels, feed, etc.
Code was reviewed by all of us and now looks good.

I would merge this, finally :-D

Note for after this is merged: create a PR that removes both the ic_notifications and ic_pin icons in the drawable-night folders, as the way icons work has been changed. I will not do this in this PR since ic_pin is unrelated.

Stypox · 2022-03-20T10:07:44Z

Update Database Wiki page

@TobiGr or @litetex could you take care of that? I don't know what should be updated (just the screenshot of an inspected database?)

litetex · 2022-03-20T16:47:31Z

@Stypox @TobiGr
Not sure how the graphic is built is there a manual somewhere?

Stypox · 2022-03-20T17:29:09Z

I think you can view it if you inspect the app's database of a running app, but I never did that

Stypox · 2022-03-26T20:41:12Z

@TiA4f8R could you point out here the issues you found with new streams notifications?

AudricV · 2022-03-26T20:50:00Z

These are not really issues but improvements (I didn't test deeply the feature):

show the avatar of the channel when selecting channels to recieve subscriptions;
in the notifications, be able to click on a specific stream to open it instead of being redirected to the channel itself;
(maybe) show a bell icon to enable/disable notifications at the right of the subscribe button, like on YouTube, instead of showing a snackbar.

litetex · 2022-03-26T21:01:06Z

@Stypox

I created the follwoing database-diagramm with https://dbeaver.io/ (FOSS):

Feel free to update the wiki if you feel like this is correct.

Stypox · 2022-03-27T07:53:16Z

@litetex done, thanks

Stypox mentioned this pull request Jun 23, 2019

More customizable behavior for What's New #719

Closed

Koitharu marked this pull request as ready for review June 30, 2019 13:11

Stypox mentioned this pull request Jul 1, 2019

Notification for new video #1086

Closed

theScrabi added the feature request Issue is related to a feature in the app label Jul 21, 2019

This comment has been minimized.

Sign in to view

Stypox mentioned this pull request Sep 8, 2019

Feature: New video Notifications #2608

Closed

3 tasks

gkeegan mentioned this pull request Sep 9, 2019

[Request] Per-Channel New Video Notifications #2609

Closed

Stypox mentioned this pull request Dec 28, 2019

Closed #2901

Closed

Stypox linked an issue Mar 30, 2020 that may be closed by this pull request

More customizable behavior for What's New #719

Closed

Stypox mentioned this pull request Apr 10, 2020

Background subscription scan service to generate notifications #3372

Closed

Stypox added the feed Issue is related to the feed label Apr 10, 2020

Stypox linked an issue Apr 16, 2020 that may be closed by this pull request

directly open the videos from mobile's notification screen which are suggested by youtube app #3443

Closed

Koitharu force-pushed the feature/notifications branch 2 times, most recently from 112b084 to e396cb8 Compare April 18, 2020 11:06

This comment has been minimized.

Sign in to view

Stypox modified the milestones: 0.20.0, 0.19.4 Apr 20, 2020

B0pol previously requested changes May 10, 2020

View reviewed changes

Stypox requested changes May 18, 2020

View reviewed changes

Stypox removed this from the 0.19.4 milestone May 28, 2020

TobiGr requested review from litetex and removed request for AudricV February 21, 2022 20:37

Update android work library version to 2.7.1

a0dc66a

Stypox reviewed Feb 23, 2022

View reviewed changes

app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationWorker.kt Outdated Show resolved Hide resolved

Small code improvements

5fea12d

Removed some non-translatable strings and just hardcoded them in the code, like it's being done for other string separators. This also deduplicates some code by using Localization. Used some Kotlin feature to reduce code.

Stypox force-pushed the feature/notifications branch from 8ffcb16 to 5fea12d Compare February 26, 2022 09:40

Stypox mentioned this pull request Mar 1, 2022

Migrate app update checker to AndroidX Work #7975

Merged

5 tasks

litetex removed their request for review March 2, 2022 19:36

Stypox added 2 commits March 19, 2022 21:55

Merge branch 'dev' into pr2335

6e8c9f9

Stypox force-pushed the feature/notifications branch from cb83d33 to 6e8c9f9 Compare March 19, 2022 21:29

Make "Player notification" PreferenceScreen searchable

66fffce

Stypox approved these changes Mar 19, 2022

View reviewed changes

Stypox merged commit 2623f0e into TeamNewPipe:dev Mar 20, 2022

Stypox mentioned this pull request Mar 20, 2022

Add more tests for methods involving the database #8080

Closed

5 tasks

Stypox mentioned this pull request Mar 20, 2022

Remove pin and notifications night icons #8081

Merged

5 tasks

Stypox mentioned this pull request Apr 16, 2022

Release 0.23.0 (please TEST!) #8230

Closed

12 tasks

SameenAhnaf mentioned this pull request Apr 16, 2022

Move Player Notifications setting into Notifications section #8232

Closed

5 tasks

SydneyDrone mentioned this pull request May 29, 2022

Add database test for SubscriptionManager #8456

Merged

4 tasks

ghost mentioned this pull request Jun 1, 2022

Notification for new streams libre-tube/LibreTube#346

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New streams notifications #2335

New streams notifications #2335

Koitharu commented May 9, 2019 •

edited by Stypox

Loading

Redirion commented May 10, 2019

Koitharu commented May 10, 2019

Stypox commented May 10, 2019

This comment has been minimized.

ShareASmile commented Mar 29, 2020 •

edited

Loading

Flam3z commented Apr 2, 2020 •

edited

Loading

Koitharu commented Apr 11, 2020

wb9688 commented Apr 12, 2020

This comment has been minimized.

B0pol commented May 10, 2020

B0pol left a comment •

edited

Loading

B0pol commented May 10, 2020

Stypox left a comment

Stypox May 18, 2020

Stypox May 18, 2020

Stypox May 18, 2020

Koitharu Jul 16, 2020

Stypox May 18, 2020

Stypox May 18, 2020

Stypox May 18, 2020

Stypox May 18, 2020

Koitharu Jul 16, 2020

Stypox left a comment •

edited

Loading

Stypox commented Feb 25, 2022

sonarcloud bot commented Mar 19, 2022

Stypox left a comment •

edited

Loading

Stypox commented Mar 20, 2022

litetex commented Mar 20, 2022

Stypox commented Mar 20, 2022

Stypox commented Mar 26, 2022

AudricV commented Mar 26, 2022

litetex commented Mar 26, 2022

Stypox commented Mar 27, 2022

New streams notifications #2335

New streams notifications #2335

Conversation

Koitharu commented May 9, 2019 • edited by Stypox Loading

Redirion commented May 10, 2019

Koitharu commented May 10, 2019

Stypox commented May 10, 2019

This comment has been minimized.

ShareASmile commented Mar 29, 2020 • edited Loading

Flam3z commented Apr 2, 2020 • edited Loading

Koitharu commented Apr 11, 2020

wb9688 commented Apr 12, 2020

This comment has been minimized.

B0pol commented May 10, 2020

B0pol left a comment • edited Loading

Choose a reason for hiding this comment

B0pol commented May 10, 2020

Stypox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Stypox left a comment • edited Loading

Choose a reason for hiding this comment

Stypox commented Feb 25, 2022

sonarcloud bot commented Mar 19, 2022

Stypox left a comment • edited Loading

Choose a reason for hiding this comment

Stypox commented Mar 20, 2022

litetex commented Mar 20, 2022

Stypox commented Mar 20, 2022

Stypox commented Mar 26, 2022

AudricV commented Mar 26, 2022

litetex commented Mar 26, 2022

Stypox commented Mar 27, 2022

Koitharu commented May 9, 2019 •

edited by Stypox

Loading

ShareASmile commented Mar 29, 2020 •

edited

Loading

Flam3z commented Apr 2, 2020 •

edited

Loading

B0pol left a comment •

edited

Loading

Stypox left a comment •

edited

Loading

Stypox left a comment •

edited

Loading