Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Player Notifications setting into Notifications section #8232

Closed
5 tasks done
SameenAhnaf opened this issue Apr 16, 2022 · 1 comment · Fixed by #9580
Closed
5 tasks done

Move Player Notifications setting into Notifications section #8232

SameenAhnaf opened this issue Apr 16, 2022 · 1 comment · Fixed by #9580
Labels
bug Issue is related to a bug

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Apr 16, 2022 •
edited by Stypox
Loading

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

Latest version after #2335 got merged

Expected behavior

As new stream notifications are now implemented, it's expected to see player notifications as a separate sub-section in Notifications.

Actual behavior

Player notifications are moved to Appearence section.
@SameenAhnaf SameenAhnaf added the bug Issue is related to a bug label Apr 16, 2022
@SameenAhnaf SameenAhnaf mentioned this issue Nov 9, 2022
Closed
6 tasks
@pratyaksh1610 pratyaksh1610 mentioned this issue Dec 21, 2022
Merged
5 tasks
@SameenAhnaf
Copy link
Collaborator Author

Closing in favor of #9587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved player notification setting to notification section pratyaksh1610/NewPipe
1 participant
@SameenAhnaf