refactor: cmd-79 rename tacc cms settings #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wesleyboar
changed the title
PORTAL_ to FAVICON & LOGOFAVICON, LOGO, TACC_ → PORTAL
wesleyboar
changed the title
FAVICON, LOGO, TACC_ → PORTALFAVICON, LOGO, TACC_ → PORTAL
wesleyboar
changed the title
FAVICON, LOGO, TACC_ → PORTALFAVICON, LOGO, TACC_ → PORTAL_
With this update, there is an unexpected and bewildering UI change: - the navbar at 992px is collapsed - it should only collapse at 991px - this behavior is different than when using Core-CMS v4.8.3
wesleyboar
changed the title
FAVICON, LOGO, TACC_ → PORTAL_
wesleyboar
changed the title
wesleyboar
changed the base branch from
main
to
enhance/CMD-182-design-tokens
wesleyboar
deleted the
feat/cmd-79-support-new-core-cms-settings-prefix
branch
jarosenb
added a commit
that referenced
this pull request
Oct 17, 2024
…le to Blue (#476) * chore: CMD-182 do not use deprecated CSS vars * enhance: CMD-182 use Core-CMS that has design tokens * deps: CMD-182 core-styles and postcss… * feat: CMD-182 use tokens core-v3 * fix(cep): dev, cms tag via hash because latest image is not used * fix: CMD-182 color fix snippet was using core-v2 * feat: CMD-182 use built tokens core-v3 * fix: CMD-182 cms tag actual design tokens i hope * refactor: CMD-182 delete unnecessary overrides Core Styles v3 does not distinguish Portal colors. So, Portal need not worry about overrides. * fix: CMD-182 cms w/ updated tokens * fix: CMD-182 cms w/ updated tokens & fixed rgb() * fix: CMD-182 remove outdated css hack Not necessary since Core-Styles 45dc5aa1. * deps: CMD-182 core-styles colors.accent.1.light * deps: CMD-182 core-styles v2.32.0 core-cms v4.15.0 * fix(tup-cms): missing v in tag * chore: CMD-182 delete unnecessary snippet * fix: CMD-182 do not use --weak accent color var It is deprecated. * deps: CMD-182 core-styles v2.32.1 core-cms v4.15.1 * deps: CMD-182 core-cms v4.15.2 * chore: CMD-182 delete unnecessary snippet override Differences form Core-CMS resolved in Core-CMS commit 9efb52ff. * refactor: Core-CMS v4.13.0 branding settings * refactor: cmd-79 rename tacc cms settings (#416) * chore: cmd-79/tv3-181 FAVICON → PORTAL_FAVICON * refactor: cmd-79/tv3-181 LOGO → PORTAL_LOGO * refactor: cmd-79/tv3-181 TACC_ → PORTAL_ * feat: cmd-79/tv3-181 Core-CMS image placeholder * test: cmd-79/tv3-181 new Core-CMS image * fix: correct branch translation to core-cms image * fix!: cmd-79 core-cms backwards-compatibility bugs With this update, there is an unexpected and bewildering UI change: - the navbar at 992px is collapsed - it should only collapse at 991px - this behavior is different than when using Core-CMS v4.8.3 * style: cmd-79 remove newline to simplify diff * fix: cmd-79 nav overflows header at certain screen widths * refactor: rename old Core-CMS settings to new * docs: PORTAL_NAV_WIDTH moved to correct section * deps: core-cms v4.15.3 candidate * deps: core-cms v4.15.3 candidate (update) * deps: core-cms v4.16, core-styles v2.33 * deps: core-styles v2.33.1 * chore: core-cms v4.16.1 * feat: core-cms v4.17.1 - raw markup template (though tup-cms does not enable it) - muted container section (enabled by default) * chore(tup-cms): remove unused templates --------- Co-authored-by: Jake Rosenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support TACC/Core-CMS rename of some settings.
Related
Changes
Testing & UI
Will test via: