refactor: cmd-79 rename tacc cms settings

[wesleyboar]

Overview

Reword TACC_ settings as PORTAL_ settings.

^{Because (A) Core-CMS is used by clients, so "TACC_LOGO" is a weird setting (because they have their own logo) and (B) The CMS and Portal are aspects of a website that is called Portal in TACC-speak (and I am done grumbling against it).}

Status

• test
  • refactor: cmd-79 rename tacc cms settings tup-ui#416
  • refactor: cmd-79 rename tacc cms settings Core-CMS-Custom#265
  • https://github.com/TACC/Core-Portal-Deployments/pull/43

Related

• CMD-79
• continues feat: TV3-181/cmd-79 change FAVICON & LOGO prefix #795
• required by:
  • refactor: cmd-79 rename tacc cms settings tup-ui#416
  • refactor: cmd-79 rename tacc cms settings Core-CMS-Custom#265
  • https://github.com/TACC/Core-Portal-Deployments/pull/43
• includes:
  • feat: custom nav width via PORTAL_NAV_WIDTH #837

Changes

• renamed settings

Testing & UI

https://github.com/TACC/Core-Portal-Deployments/pull/43

[taoteg]

PORTAL_MANAGES_AUTH works for me, it has the PORTAL_ prefix and explicitly states what it does.
PORTAL_IS_CORE feels too ambiguous imo. Question: What property/aspect of a portal configuration is this supposed to be indicating if not that the AUTH source is the django container?

Aside: I do so which we had called Core-Portal something less overloaded (Core-Workbench, Core-Dashboard, Core-Django, Core-Workspace, literally anything else that would not conflate the use of portal), but it is what it is now...

[wesleyboar]

I changed PORTAL_IS_CORE to PORTAL_IS_TACC_CORE_PORTAL.

Goal is clarity and accuracy. I see the setting is not solely used to describe Core-Portal managing auth. It also describes code that Core-Portal expects but is not necessary for all portals (e.g. TUP, or a future one with a better way to share header) nor related to auth.

Perhaps we revisit PORTAL_MANAGES_AUTH as a setting if we make CMS support LDAP.

[wesleyboar]

I tested this on every [Camino-deployed] Core-CMS website —

• https://github.com/TACC/Core-Portal-Deployments/pull/43

— and the only bug was because of upgrading ECEP to v4.9+.

Important

Merging based on approval of https://github.com/TACC/Core-Portal-Deployments/pull/43.