Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: s-footer link color affects buttons #392

Merged
merged 3 commits into from
Sep 6, 2024
Merged

fix: s-footer link color affects buttons #392

merged 3 commits into from
Sep 6, 2024

Conversation

wesleyboar
Copy link
Member

Overview / Changes

  • Do not let s-footer link color affect buttons.
  • Add style for an <hr> inside an s-footer.

Related

Testing

  1. Open http://localhost:3000/components/detail/s-footer--complex.
  2. Verify button has white text.
  3. Hover over button.
  4. Verify button still has white text.

UI

Core-Styles.392.mov

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Sep 6, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Sep 6, 2024
@wesleyboar wesleyboar merged commit 26bd9f8 into main Sep 6, 2024
3 of 5 checks passed
@wesleyboar wesleyboar deleted the fix/s-footer-link-color-affects-buttons branch September 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar