fix: s-footer link color affects buttons (#392)

* fix: s-footer link color affect buttons * feat: s-footer hr * build: s-footer hr
TACC · Sep 6, 2024 · 26bd9f8 · 26bd9f8
1 parent fb8147b
commit 26bd9f8
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 7 deletions.
diff --git a/dist/core-styles.cms.css b/dist/core-styles.cms.css
diff --git a/dist/core-styles.portal.css b/dist/core-styles.portal.css
diff --git a/dist/trumps/s-footer.css b/dist/trumps/s-footer.css
diff --git a/src/lib/_imports/trumps/s-footer.css b/src/lib/_imports/trumps/s-footer.css
@@ -1,4 +1,5 @@
 @import url("../tools/selectors.css");
+@import url("../components/c-button.selectors.css");
 
 @import url("./s-footer.properties.css");
 
@@ -18,11 +19,12 @@
   padding-inline: var(--pad-horz--thin);
 }
 
-.s-footer a:not(:hover) {
-  color: var(--global-color-primary--light);
+.s-footer a:not(:--c-button, :hover) {
+    color: var(--global-color-primary--light)
 }
-.s-footer a:hover {
-  color: var(--global-color-accent--light-old);
+
+.s-footer a:not(:--c-button):hover {
+    color: var(--global-color-accent--light-old)
 }
 
 .s-footer :--heading {
@@ -35,3 +37,8 @@
 }
 .s-footer > p:first-of-type { margin-top: 0; }
 .s-footer > p:last-of-type { margin-bottom: 0; }
+
+/* To suggest semantic solution for horiontal lines */
+.s-footer hr {
+    margin-block: 1rem;
+}
diff --git a/src/lib/_imports/trumps/s-footer/s-footer.hbs b/src/lib/_imports/trumps/s-footer/s-footer.hbs
@@ -34,6 +34,8 @@
       <a href="#">Security and Compliance</a><br>
       <a href="#">Help</a>
     </p>
+    <hr>
+    <a href="#" class="c-button c-button--primary">Button</a>
   </div>
   {{else}}
     <p>