Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-182 design tokens core-v3 concept #375

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 23, 2024

Overview

Add Core v3 color tokens.

Important

Changes portal accent color from purple to blue.

Related

Changes

  • changed colors--portal.css to use blue accent
  • changed colors.accent(…)css to use design tokens
  • removed colors.accent--*.css
  • added colors.accent.v3.css
  • added colors.v3.css

Testing

Complicated.

UI

Skipped.

@github-actions github-actions bot added the enhancement Improvements or additions to existing features label Aug 23, 2024
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Aug 23, 2024
@wesleyboar wesleyboar changed the title feat: CMD-182 use tokens core-v3 feat: CMD-182 design tokens core-v3 Aug 23, 2024
@wesleyboar wesleyboar marked this pull request as ready for review August 27, 2024 17:31
@wesleyboar wesleyboar merged commit b1425d2 into enhance/CMD-182-design-tokens Aug 27, 2024
@wesleyboar wesleyboar deleted the enhance/CMD-182-design-tokens--v3-colors branch August 27, 2024 17:31
@wesleyboar wesleyboar changed the title feat: CMD-182 design tokens core-v3 feat: CMD-182 design tokens core-v3 concept Sep 5, 2024
wesleyboar added a commit that referenced this pull request Sep 5, 2024
* Initial tokens

* Revert "Initial tokens"

This reverts commit 0df274d.

* Updates since adding v3

* feat: CMD-182 save v3 design tokens

* fix: CMD-182 wrong tokens keys normal/medium

* fix: CMD-182 token format v4 isntead of v3

`format('style-dictionary3')`

Must I find/replace every time I update tokens? Grumble.

* fix: CMD-182 token groups not unique, -xx to 2x

* refactor: design-tokens, no rgb vars, rel. colors

* docs: CMD-182 do not suggest var in rgb

- not supported by Safari v15*
- not polyfilled by postcss-relative-color-syntax

* Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.

* fix: CMD-182 do not use var in rgb

- not supported by Safari v15*
- not polyfilled by postcss-relative-color-syntax

* Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.

* fix: CMD-182 tokens core-v3 traffic

* feat: CMD-182 tokens core-v3 light

* build: CMD-182 tokens core-v2 light

* feat: CMD-182 design tokens core-v3 (#375)

* feat: CMD-182 use tokens core-v3

* build: CMD-182 tokens core-v3 light

* chore: CMD-182 delete dist of deleted files

* enhance: CMD-182 revise color grid

- add fifth accent
- flatten color token names

* enhance: CMD-182 revise color grid

- add fifth accent
- flatten color token names

* feat: deprecate alt/weak accent colors

These are like the values TACC/tup-ui uses.

* enhance: std message colors for portals

* build: std message colors for portals

* fix: CMD-182 revert color grid, keep new names

* refactor: brand color tokens v1, v2, v3, ds

* fix: CMD-182 revert from v3 to v2 (prep for merge)

Prepare to merge to base, then return to v3 a smarter way.

* chore: CMD-182 remove explicit v2 dist

* docs: CMD-182 do not distinguish colors per client

All clients use the same colors now.

* chore: show deprecated colors as such in demo

* fix: show deprecated colors as such in demo

* fix: deprecated colors not loading

* fix: deprecated colors not loading (v3)

* chore: show more deprecated colors as such

* fix: deprecated `on-light`/`dark` colors wrong

* 2024-08-26 tokens

- Primitives: v1, v2, v3, ds
- Tokens: dark, light

* (for real) 2024-08-26 tokens 

- Primitives: v1, v2, v3, ds
- Tokens: dark, light

* refactor: rename src/build to src/buuild-styles

* renamed Primitive modes to match Token groups

* fix: CMD-182 build tokens from single Figma export

* chore: CMD-182 token build better logging

* fix: CMD-182 token build excluding ever more data

* feat: CMD-182 use new token files

* fix: CMD-182 rgb relative color syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or additions to existing features minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant