Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: CMD-182 design tokens #372

Merged
merged 45 commits into from
Sep 5, 2024
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 23, 2024

Overview

Add and use design tokens.

Important

Removed --global-color-…-rgb variables.

No demo. Affected clients are updated via TACC/Core-CMS-Resources#200.

before after
rgba(var(--global-color-…rgb), …) rgb( from var(--global-color-…rgb) r g b / …)

Important

Changed Portal accent color from purple to blue.
Affected clients updated via TACC/tup-ui#476.

Important

Changed --global-color-acent--light from #86aeff to #3d6acc

Status

  • Use design tokens for colors.
  • Add v3 colors.
  • Design v3 buttons and pills.
  • Use "Tokens Studio for Figma" as source of tokens
  • Add script to adjust tokens .json per Core-Styles version.
  • Test successfully on all clients.
  • Update design software:
    • move spacing to new Core project
    • migrate font weight name/value-mapping to Core-Styles
    • delete font weight variables
    • move ds tokens to new project

Related

Changes

  • adds design tokens
  • adds build-tokens.js, and build:tokens NPM script
  • renames build.js to build-styles.js
  • changes global CSS vars to use design tokens
  • removes --global-color-…-rgb vars
  • removed vars from %x-overlay--callout ⚠️
  • changed colors--portal.css to use blue accent ⚠️
  • removed colors.accent--*.css
  • added colors.accent.v3.css
  • added colors.v3.css

Testing & UI

UI

Skipped.

  • The portal accent color changed from purple to blue.
  • The --global-color-acent--light changed from #86aeff to #3d6acc.

Build

  1. Delete tokens/*.json.
  2. Run npm run buiild:css.
  3. Verify tokens/*.json return with no changes.
  4. Verify dist/ is unchanged.
CMD-182.Build.mov

@github-actions github-actions bot added the enhancement Improvements or additions to existing features label Aug 23, 2024
@wesleyboar wesleyboar added minor A feature in backward-compatible manner major An incompatible API change and removed minor A feature in backward-compatible manner labels Aug 23, 2024
@wesleyboar wesleyboar changed the title feat: CMD-182 save v3 design tokens enhance: CMD-182 design tokens Aug 23, 2024
- not supported by Safari v15*
- not polyfilled by postcss-relative-color-syntax

* Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.
- not supported by Safari v15*
- not polyfilled by postcss-relative-color-syntax

* Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.
@wesleyboar wesleyboar marked this pull request as ready for review August 23, 2024 14:30
wesleyboar and others added 4 commits August 23, 2024 10:28
* feat: CMD-182 use tokens core-v3

* build: CMD-182 tokens core-v3 light

* chore: CMD-182 delete dist of deleted files

* enhance: CMD-182 revise color grid

- add fifth accent
- flatten color token names

* enhance: CMD-182 revise color grid

- add fifth accent
- flatten color token names

* feat: deprecate alt/weak accent colors

These are like the values TACC/tup-ui uses.

* enhance: std message colors for portals

* build: std message colors for portals

* fix: CMD-182 revert color grid, keep new names

* refactor: brand color tokens v1, v2, v3, ds

* fix: CMD-182 revert from v3 to v2 (prep for merge)

Prepare to merge to base, then return to v3 a smarter way.

* chore: CMD-182 remove explicit v2 dist
All clients use the same colors now.
wesleyboar and others added 24 commits August 27, 2024 14:02
- Primitives: v1, v2, v3, ds
- Tokens: dark, light
- Primitives: v1, v2, v3, ds
- Tokens: dark, light
@wesleyboar wesleyboar merged commit 212f167 into main Sep 5, 2024
@wesleyboar wesleyboar deleted the enhance/CMD-182-design-tokens branch September 5, 2024 17:33
@wesleyboar wesleyboar added minor A feature in backward-compatible manner and removed major An incompatible API change labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or additions to existing features minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant