Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove duplicate entries in Turkish translation #2782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove duplicate entries in Turkish translation #2782

wants to merge 1 commit into from
+139 −135

Conversation

hasanbeder
Copy link

Description of Changes

This PR fixes the following issues in messages_tr_TR.properties:

What was fixed

  • Removed duplicate entries:
    • home.PDFToMarkdown.title (duplicate at line 1377)
    • home.PDFToMarkdown.desc (duplicate at line 1378)
    • PDFToMarkdown.tags (duplicate at line 1379)
  • Aligned file structure with reference file (messages_en_GB.properties)
  • Reduced total line count from 1379 to 1375 lines

Why the change was made

  • To fix GitHub Actions validation errors
  • To maintain consistency with the reference file structure
  • To eliminate redundant translations

Testing Performed

  • Verified file structure matches reference file
  • Confirmed no duplicate entries remain
  • Validated line count matches reference file (1375 lines)

Closes #(issue_number)

Checklist

General

Documentation

Testing

  • I have verified the translation file structure
  • I have checked for any remaining duplicate entries

@hasanbeder
fix: Remove duplicate entries in Turkish translation
edf99e2 
Fixed GitHub Actions validation errors in messages_tr_TR.properties:
- Removed duplicate entries for PDFToMarkdown section
- Reduced total line count from 1379 to 1375 lines
- Aligned file structure with messages_en_GB.properties
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

🚀 Translation Verification Summary

🔄 Reference Branch: main-branch-messages_en_GB.properties

📃 File Check: messages_tr_TR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Too many lines: 1375 (reference) vs 1379 (current). Please verify if there is an additional line that needs to be removed.
  1. Test Status: ✅ Passed
  2. Test Status: ❌ Failed
  • Issue:
    • duplicate entries were found:
      • home.PDFToMarkdown.title: first at line 455, duplicate at line 1377
      • home.PDFToMarkdown.desc: first at line 456, duplicate at line 1378
      • PDFToMarkdown.tags: first at line 457, duplicate at line 1379

❌ Overall Check Status: Failed

@hasanbeder please check your translation if it conforms to the standard. Follow the format of messages_en_GB.properties

@Ludy87
Copy link
Contributor

Ludy87 commented Jan 24, 2025

#2779

It would be better to edit the existing PR instead of starting a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frooodle Frooodle Awaiting requested review from Frooodle Frooodle is a code owner

@reecebrowne reecebrowne Awaiting requested review from reecebrowne reecebrowne is a code owner

@Ludy87 Ludy87 Awaiting requested review from Ludy87 Ludy87 is a code owner

@DarioGii DarioGii Awaiting requested review from DarioGii DarioGii is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files. Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasanbeder @Ludy87