-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/VDX-341 #297
base: feature/SPRIND-137
Are you sure you want to change the base?
feature/VDX-341 #297
Changes from 13 commits
7504a67
b7dc203
4b0c592
ccbd912
ebda0c0
fbdad8f
8880f69
dfd106f
36c0635
a58764c
877c381
1cfce94
306c946
06944fa
fbdce51
9a6ccb7
aa4cb0a
32bece4
df3cbbd
2becfb4
1a6b469
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import { IPresentationDefinition } from '@sphereon/pex' | ||
import { DcqlQuery } from '@sphereon/ssi-types' | ||
|
||
export type PresentationDefinitionItem = { | ||
id: string | ||
|
@@ -8,10 +9,11 @@ export type PresentationDefinitionItem = { | |
name?: string | ||
purpose?: string | ||
definitionPayload: IPresentationDefinition | ||
dcqlPayload?: DcqlQuery | ||
createdAt: Date | ||
lastUpdatedAt: Date | ||
} | ||
|
||
export type NonPersistedPresentationDefinitionItem = Omit<PresentationDefinitionItem, 'id' | 'createdAt' | 'lastUpdatedAt'> | ||
export type PartialPresentationDefinitionItem = Partial<PresentationDefinitionItem> | ||
export type PresentationDefinitionItemFilter = Partial<Omit<PresentationDefinitionItem, 'definitionPayload'>> // TODO add logic to linearize & hash definitionPayload into a separate column so we can filter on it? | ||
export type PresentationDefinitionItemFilter = Partial<Omit<PresentationDefinitionItem, 'definitionPayload' | 'dcqlPayload'>> // TODO add logic to linearize & hash definitionPayload into a separate column so we can filter on it? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we move this todo to a ticket and link it on the comment? it can easily be lost on the code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually I changed my mind and removed the TODO. The same presentation definition payload can be used for multiple configurations and retrieving records by payload hash may not return the intended record or multiple records, so better to avoid it. The caller just needs to the either the unique ID or definitionId + tenantId + version to query the correct record. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any kinda of validation on this ID? for example can it be duplicated or null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The object in question is a query, the field can be anything or be omitted just like could be done with SQL queries