feature/VDX-341 #297
Open
feature/VDX-341 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml
…/VDX-341 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml
# Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml
…/VDX-341 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml
ronal2do
reviewed
Jan 7, 2025
| entity.dcqlPayload = JSON.stringify({ | ||
| credentials: [ | ||
| { | ||
| id: 'credential1', |
There was a problem hiding this comment.
is there any kinda of validation on this ID? for example can it be duplicated or null?
There was a problem hiding this comment.
The object in question is a query, the field can be anything or be omitted just like could be done with SQL queries
ronal2do
reviewed
Jan 7, 2025
| import { VerificationMethod } from '@sphereon/ssi-types' | ||
| import { JsonWebKey2020, P256Key2021, P384Key2021, P521Key2021 } from '@transmute/web-crypto-key-pair' | ||
| import { Ed25519VerificationKey2018 } from '@transmute/ed25519-key-pair' | ||
| import { EcdsaSecp256k1VerificationKey2019 } from '@transmute/secp256k1-key-pair' | ||
|
|
||
| // import { getJwaAlgFromJwk } from '@transmute/web-crypto-key-pair/dist/signatures/jws' |
There was a problem hiding this comment.
It's not my line / not commented out by me.
I typically do not remove other people's comments. Perhaps this one is very trivial, maybe it's something that still has to be hooked up in the future, I wouldn't know..
We can create a rule to clean up commented out imports, but until then I do not touch them.
ronal2do
reviewed
Jan 7, 2025
| createdAt: Date | ||
| lastUpdatedAt: Date | ||
| } | ||
|
|
||
| export type NonPersistedPresentationDefinitionItem = Omit<PresentationDefinitionItem, 'id' | 'createdAt' | 'lastUpdatedAt'> | ||
| export type PartialPresentationDefinitionItem = Partial<PresentationDefinitionItem> | ||
| export type PresentationDefinitionItemFilter = Partial<Omit<PresentationDefinitionItem, 'definitionPayload'>> // TODO add logic to linearize & hash definitionPayload into a separate column so we can filter on it? | ||
| export type PresentationDefinitionItemFilter = Partial<Omit<PresentationDefinitionItem, 'definitionPayload' | 'dcqlPayload'>> // TODO add logic to linearize & hash definitionPayload into a separate column so we can filter on it? |
There was a problem hiding this comment.
can we move this todo to a ticket and link it on the comment? it can easily be lost on the code
There was a problem hiding this comment.
Actually I changed my mind and removed the TODO. The same presentation definition payload can be used for multiple configurations and retrieving records by payload hash may not return the intended record or multiple records, so better to avoid it. The caller just needs to the either the unique ID or definitionId + tenantId + version to query the correct record.
…llenge (did:web support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEWARE this is based against SPRIND-137 so do not merge to develop until that one is merged,