-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize dumbbuffer #33
Modernize dumbbuffer #33
Conversation
Looking at Should |
c3c847a
to
8134dc3
Compare
7ee9556
to
a2fd839
Compare
Since a lot of PRs started to require the buffer trait, I have now split of #38. Open points remaining:
|
a2fd839
to
858687c
Compare
858687c
to
9140729
Compare
These changes have been pulled from another PR, so closing this one. To address your questions:
That's a good question. I'm not sure a
I don't plan on doing that until at least after the functionality for the control module is done. But it will happen eventually. |
Nevermind - I jumped the gun and realized that the actual dumbbuffer.rs changes were not pulled in. |
Many of my PR did depend on the buffer PR, but contain additional commits. (like this one.) |
Hey Slabity,
to speed up #25 a bit, I tried to fix the buffer and dumbbuffer apis and would like to have some feedback.
Some additional questions, that showed themselves, when implementing this:
str_internals
is not going to be stablized any time soon, while nll is already available.