Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement cursor functions #34

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Reimplement cursor functions #34

merged 1 commit into from
Nov 4, 2020

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented May 6, 2019

Building upon buffer support in #33, I quickly added the cursor functions.

This is a bit closer to the libdrm-function then the old implementation (on master). It allows None being passed in as a buffer, instead of providing a clear_cursor function. Not sure though which is better for rusty bindings.

@Drakulix Drakulix force-pushed the feature/cursor branch 2 times, most recently from 3ceabdb to ece7383 Compare May 12, 2019 13:43
@Drakulix
Copy link
Member Author

Rebased onto #38

@Drakulix Drakulix force-pushed the feature/cursor branch 3 times, most recently from 63ed1c6 to 031970b Compare May 17, 2019 09:02
@Drakulix
Copy link
Member Author

@Slabity Any specific reason against this PR?

  • I could combine the set-ioctls into a single one with an optional hotspot and automatic fallback?
  • Or re-introduce clear_cursor instead of set_cursor with an optional buffer again?

@Drakulix
Copy link
Member Author

Rebased on current develop (99be0f9) without changes.

@Slabity Slabity merged commit 136e9b9 into Smithay:develop Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drakulix @Slabity